osmo-pcu[master]: Sanitizer build fix for invalid value of variable of type eg...

arvind.sirsikar gerrit-no-reply at lists.osmocom.org
Wed Jan 11 09:39:54 UTC 2017


Patch Set 3:

Neels,
My apologies for delay in response. I was in vacation. I keep track of things which needs to be 
done. No further follow ups are required. It may create noise for others as pointed out by many earlier.
Do we have agreement yet about what needs to be done?. My understanding is, we are still going ahead with
memset of “egprs_puncturing_values punct” with minor modification in commit message. Confirm if my understanding is correct. If my understanding is correct, I can re submit the patch with modification I am intending to do. Otherwise I prefer it is reassigned to someone else. For me, priority is pushing https://gerrit.osmocom.org/#/c/1216/ and https://gerrit.osmocom.org/#/c/1512/ . out of which https://gerrit.osmocom.org/#/c/1216/ is pending for ~2 months for the reason I am not aware of.
Furthermore, as you said “enum egprs_puncturing_values” is added by me in commit 7a05b039c835868eff34308d861edfeb28d1763b. however unsigned “int gprs_rlc_mcs_cps” is added by “https://git.osmocom.org/osmo-pcu/commit/?id=9e8593917f3e301c3487f73430ce416a08360ce8”. Which lacked any assert for invalid input to the function
Thanks,
Aravind Sirsikar

-- 
To view, visit https://gerrit.osmocom.org/1411
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice54edc7e4a936eb2f2dd8a243673a30dceef542
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: No


More information about the gerrit-log mailing list