osmo-gsm-manuals[master]: SGSN: add Auth. policy, NS Statistics and BSSGP state examples

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jan 9 19:47:30 UTC 2017


Patch Set 4: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/1535/4/OsmoSGSN/chapters/configuration.adoc
File OsmoSGSN/chapters/configuration.adoc:

Line 84: The combination of MCC and MNC fully identifies subscriber's
"a subscriber's home network"

Maybe also include the nice explanation about IMSI starting with MCC and MNC that I saw in the other patch?


Line 99: OsmoSGSN(config-sgsn)# exit
I think we don't need to show the exits here.
BTW, 'end' once instead of multiple 'exit' is quicker.


https://gerrit.osmocom.org/#/c/1535/4/OsmoSGSN/chapters/overview.adoc
File OsmoSGSN/chapters/overview.adoc:

Line 61: OsmoSGSN uses the libgtp implementation originating from OpenGGSN.It
this looks like a change by mistake


-- 
To view, visit https://gerrit.osmocom.org/1535
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0164f418e453672321eed00bbc454c1e223ea158
Gerrit-PatchSet: 4
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: ikostov <ikostov at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list