This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/1546 OML: Fixup for CID 159533 oml_ipa_set_attr() is using gsm_objclass2mo() to determine the *mo object. However it is possible that gsm_objclass2mo() a null-pointer. The code following up is using *mo without checking. This commit adds an additional check to ensure that *mo is not used without checking. Change-Id: Ia2cc9bc504c46ca3843c43d712cd8649bfae9526 --- M src/common/oml.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/46/1546/1 diff --git a/src/common/oml.c b/src/common/oml.c index 8ccfcc6..88c9abd 100644 --- a/src/common/oml.c +++ b/src/common/oml.c @@ -1048,6 +1048,8 @@ rc = oml_tlv_parse(&tp, foh->data, msgb_l3len(msg) - sizeof(*foh)); if (rc < 0) { mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst); + if (!mo) + return oml_fom_ack_nack(msg, NM_NACK_OBJINST_UNKN); oml_tx_failure_event_rep(mo, OSMO_EVT_MAJ_UNSUP_ATTR, "New value for IPAC Set Attribute not " "supported\n"); -- To view, visit https://gerrit.osmocom.org/1546 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2cc9bc504c46ca3843c43d712cd8649bfae9526 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de>