osmo-gsm-manuals[master]: SGSN: add Auth. policy, NS Statistics and BSSGP state examples

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jan 9 10:49:49 UTC 2017


Patch Set 2: Code-Review-1

(13 comments)

Here's me nitpicking on doc again. Also found minor mistakes.

https://gerrit.osmocom.org/#/c/1535/2/OsmoSGSN/chapters/configuration.adoc
File OsmoSGSN/chapters/configuration.adoc:

Line 73: Authorization determines whether particular subscriber can access
"whether a particular"


Line 78: `accept-all`: When this option is selected then all IMSIs will
style nitpick: maybe drop this part: "When this option is selected then"

(otherwise replace "then" with a comma)


Line 79: be accepted. Using this policy option can be dangerous.
dangerous how? My BTS may explode violently?


Line 81: `acl-only`: In this case you will allow SGSN to accept only IMSIs,
maybe drop "In this case you will allow SGSN to"


Line 82: which are explicitly white-listed by the Access Control List (ACL) and
comma before "and"


Line 85: `closed`: This option allows you to accept only home network subscribers
maybe drop "This option allows you to"

End the sentence after "subscribers."


Line 86: either the ones, which are in the ACL or MCC/MNC match.
rather first only explain what home subscribers are (the MCC + MNC part). In the end add a hint that the ACL is also heeded.


Line 89: `remote`: When this authorization option is selected then the GSUP protocol
maybe drop "When this authorization option is selected then"


Line 91: only will be used.
"will be used, only" or "Only remote..."


Line 94: .Example: How to assign or change current authorization policy follows:
Drop "How to", drop "current" and drop "follows"


Line 108: <2> Saves current changes to cofiguration file to make this policy
"configuration"


Line 111: Other authorization policy option can be selected by using
I would drop this paragraph, it merely states the obvious.


https://gerrit.osmocom.org/#/c/1535/2/OsmoSGSN/chapters/overview.adoc
File OsmoSGSN/chapters/overview.adoc:

Line 71: Please refer to <<auth-pol>> for more details how the Authorization
"for more details on subscriber authorization."

However, it seems to me that this is a place for implementation details, listing bugs or oddities left in our code, so this doesn't really belong here?


-- 
To view, visit https://gerrit.osmocom.org/1535
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0164f418e453672321eed00bbc454c1e223ea158
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: ikostov <ikostov at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list