openbsc[master]: Migrate from OpenSSL to osmo_rand()

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Jan 6 10:16:31 UTC 2017


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/1464/6/openbsc/src/gprs/gb_proxy.c
File openbsc/src/gprs/gb_proxy.c:

Line 237: 			if (osmo_rand((uint8_t *) &bss_ptmsi,
actually, the PTMSI is not a nonce, so according to https://www.gnu.org/software/gnutls/reference/gnutls-crypto.html#gnutls-rnd-level-t it should use GNUTLS_RND_RANDOM from my understanding, as it is important for the entire session, not just for a nonec in an authentication procedure.


-- 
To view, visit https://gerrit.osmocom.org/1464
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I270c33912bf107b3c7c217d199262cc74d56ffdb
Gerrit-PatchSet: 6
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list