openbsc[master]: subscriber conn: add indicator for originating interface

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 28 18:49:29 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/1858/1/openbsc/include/openbsc/gsm_data.h
File openbsc/include/openbsc/gsm_data.h:

Line 107: enum interface_type {
interface is a bit generic. let's call it ran_type.

Might also be good to call it RAN_TYPE_GERAN_A and RAN_TYPE_UTRAN_IU.  According to specs there's also a RAN_TYPE_GERAN_IU, which we don't implement so far.  But would be good to have at least the naming in a way that states it clearly.


-- 
To view, visit https://gerrit.osmocom.org/1858
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93b870522f725170e4265a5543f6b680383d7465
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list