[PATCH] openbsc[master]: python tests: vty and smpp: speed up >10 times

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Feb 27 01:15:13 UTC 2017


Review at  https://gerrit.osmocom.org/1927

python tests: vty and smpp: speed up >10 times

osmo-python-tests now includes code that retries connecting the VTY socket and
needs no external sleep()ing. This flies through most tests without any sleep()
at all.

See osmo-python-tests.git change-id Icc337f52a93d5fe31fc4ff235ccaf4e0fe75fa39

Change-Id: I42161d9716fe5bb0ef1c56e4bfb770bb99bbca7a
---
M openbsc/tests/smpp_test_runner.py
M openbsc/tests/vty_test_runner.py
2 files changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/27/1927/1

diff --git a/openbsc/tests/smpp_test_runner.py b/openbsc/tests/smpp_test_runner.py
index 4527ac4..06fb766 100644
--- a/openbsc/tests/smpp_test_runner.py
+++ b/openbsc/tests/smpp_test_runner.py
@@ -47,7 +47,6 @@
         except OSError:
             print >> sys.stderr, "Current directory: %s" % os.getcwd()
             print >> sys.stderr, "Consider setting -b"
-        time.sleep(1)
 
         appstring = self.vty_app()[2]
         appport = self.vty_app()[0]
diff --git a/openbsc/tests/vty_test_runner.py b/openbsc/tests/vty_test_runner.py
index 821c6d3..ba3db97 100644
--- a/openbsc/tests/vty_test_runner.py
+++ b/openbsc/tests/vty_test_runner.py
@@ -49,7 +49,6 @@
         except OSError:
             print >> sys.stderr, "Current directory: %s" % os.getcwd()
             print >> sys.stderr, "Consider setting -b"
-        time.sleep(1)
 
         appstring = self.vty_app()[2]
         appport = self.vty_app()[0]

-- 
To view, visit https://gerrit.osmocom.org/1927
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42161d9716fe5bb0ef1c56e4bfb770bb99bbca7a
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list