[MERGED] openbsc[master]: vty_rest_runner.py: remove debug monitoring for TCP sockets

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Feb 25 17:04:09 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: vty_rest_runner.py: remove debug monitoring for TCP sockets
......................................................................


vty_rest_runner.py: remove debug monitoring for TCP sockets

Change-Id: I7361bb0ce5302d00ccb18dc04eeb75ee1f6844a8
---
M openbsc/tests/vty_test_runner.py
1 file changed, 0 insertions(+), 22 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Holger Freyther: Looks good to me, approved



diff --git a/openbsc/tests/vty_test_runner.py b/openbsc/tests/vty_test_runner.py
index 8b17397..ca4b276 100644
--- a/openbsc/tests/vty_test_runner.py
+++ b/openbsc/tests/vty_test_runner.py
@@ -1240,19 +1240,6 @@
                         " connected yet: %r %r" % (ip, port))
     return conn
 
-def cmd(what):
-    print '\n> %s' % what
-    sys.stdout.flush()
-    subprocess.call(what, shell=True)
-    sys.stdout.flush()
-    sys.stderr.flush()
-    print ''
-    sys.stdout.flush()
-
-def checkxxx():
-    cmd('cat /proc/net/tcp');
-    cmd('ps xua | grep osmo');
-
 def ipa_handle_small(x, verbose = False):
     s = data2str(x.recv(4))
     if len(s) != 4*2:
@@ -1277,10 +1264,6 @@
     if "0023fe040108010701020103010401050101010011" in s:
         retries = 3
         while True:
-            if proc:
-              print "\tproc.poll() = %r" % proc.poll()
-              print "\tproc.pid = %r" % proc.pid
-            checkxxx()
             print "\tsending IPA identity(%s) at %s" % (tk, time.strftime("%T"))
             try:
                 x.send(IPA().id_resp(IPA().identity(name = tk.encode('utf-8'))))
@@ -1313,19 +1296,14 @@
     if proc:
       print "\tproc.poll() = %r" % proc.poll()
       print "\tproc.pid = %r" % proc.pid
-    checkxxx()
     ipa_handle_small(bsc, verbose)
-    checkxxx()
     ipa_handle_resp(bsc, tk, verbose, proc=proc)
     if proc:
       print "\tproc.poll() = %r" % proc.poll()
-    checkxxx()
     bsc.recv(27) # MGCP msg
     if proc:
       print "\tproc.poll() = %r" % proc.poll()
-    checkxxx()
     ipa_handle_small(bsc, verbose)
-    checkxxx()
     return bsc
 
 def add_bsc_test(suite, workdir):

-- 
To view, visit https://gerrit.osmocom.org/1912
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7361bb0ce5302d00ccb18dc04eeb75ee1f6844a8
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list