osmo-hlr[master]: Make subscr parameter to db_subscr_get() optional

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 24 19:02:07 UTC 2017


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/1853/6/src/db_hlr.c
File src/db_hlr.c:

Line 57: 	if (subscr) {
the usual strategy in osmocom code (like kernel code) is to leave early.  So it should be "if (!subscr) goto out" (as we already have that label) or an explicit call to db_remove_reset() and return.


-- 
To view, visit https://gerrit.osmocom.org/1853
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83b0f4a5dacb97614721690ef55bc1311624a58e
Gerrit-PatchSet: 6
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list