openbsc[master]: add struct bsc_subscr, separating libbsc from gsm_subscriber

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Feb 24 18:45:28 UTC 2017


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1682/8/openbsc/include/openbsc/gsm_data.h
File openbsc/include/openbsc/gsm_data.h:

Line 391: 	/* List of all struct bsc_subscr used in libbsc. This llist_head is
this is highly unusual in the osmocom code base.  the llist_head of the master object is always part of a larger data structure.  Why can the users/callers not simply use the 'struct gsm_network' as talloc context?  How much of the code would have to change?


-- 
To view, visit https://gerrit.osmocom.org/1682
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
Gerrit-PatchSet: 8
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list