This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(4 comments)
thanks for your patch. Aside from the cosmetic issues outlined below (trivial to fix): What do we actually gain from this? I think adding signal handlers only make sense if we actually do something at those signals, such as sending a DELETE PDP CONTEXT to the GGSN. Maybe I don't understand your patch?
https://gerrit.osmocom.org/#/c/1902/1/sgsnemu/sgsnemu.c
File sgsnemu/sgsnemu.c:
Line 1689: signal_received=0;
we typically use 'foo = 0' and not 'foo=0'
Line 1692: if(errno == EINTR) signal_received=1;
coding style: 'if' is not a function, hence a space. The signal_received=1 belongs in a seprate line
Line 1693: else
space at EOL
Line 1704: if(!signal_received) {
if is not a function
--
To view, visit https://gerrit.osmocom.org/1902
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I546dc0a8d814527b9a96943a52f2f6b700285167
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Jovan Bunjevacki <j.bunjevacki at vipmobile.rs>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes