osmo-hlr[master]: Add global HLR struct

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri Feb 24 13:41:24 UTC 2017


Patch Set 2:

My idea is that cmdline_opts contains only exactly the values read from cmdline. The config file parsing would not write to cmdline_opts but (usually) to the global application struct.

So, say we're parsing the cmdline options into the global struct. You need that first up, to get the -c config_file option. Then you read the config file into the same global struct. Thus the VTY has higher priority and possibly overwrites cmdline things, where usually the opposite is needed. That's why clear separation might become necessary at some point.

Otherwise I like that the results from cmdline parsing are in one place where no magic happens and which no-one touches, so that we can have clear logic on what is coming from where, as well as for clear validation. Also we don't need those in the global context after the program has started. That's just my opinion.

-- 
To view, visit https://gerrit.osmocom.org/1856
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I275d3d54482f696e3378606b2406c7e0ad939e0f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list