libosmocore[master]: Expand and expose ctrl connection allocation

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Feb 23 21:12:33 UTC 2017


Patch Set 6:

Funky how the gerrit build didn't catch the osmo_sock_init_ifd() typo -- it just caused a warning on implicit function definition and wasn't caught until trying to link.

Max, thus you *definitely* did not test this patch. That's not very nice :P

And maybe we want to have some linking test in the gerrit job? difficult to link everything though.

Maybe better: disallow the implicit function definition with gcc somehow?

-- 
To view, visit https://gerrit.osmocom.org/1629
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ed809cbebfd3d7dd08b4ed9137b39ff192e32
Gerrit-PatchSet: 6
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list