[MERGED] openggsn[master]: gtp.c: Don't print ""Unknown packet flags" error message in ...

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 23 20:13:41 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: gtp.c: Don't print ""Unknown packet flags" error message in get_seq()
......................................................................


gtp.c: Don't print ""Unknown packet flags" error message in get_seq()

get_seq() is called also from contexts where GTP-U is used, and GTP-U
doesn't have sequence numbers.  Thus, it is perfectly normal if no
sequence number and/or no S flag in the header is present.

Change-Id: Ie19b95bbb4427e547843a019f5213a231a9f83da
---
M gtp/gtp.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/gtp/gtp.c b/gtp/gtp.c
index 42aa4ea..ade746a 100644
--- a/gtp/gtp.c
+++ b/gtp/gtp.c
@@ -210,7 +210,6 @@
 	} else if ((packet->flags & 0xe2) == 0x22) {	/* Version 1 with seq */
 		return ntoh16(packet->gtp1l.h.seq);
 	} else {
-		LOGP(DLGTP, LOGL_ERROR, "Unknown packet flags: 0x%02x\n", packet->flags);
 		return 0;
 	}
 }

-- 
To view, visit https://gerrit.osmocom.org/1883
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie19b95bbb4427e547843a019f5213a231a9f83da
Gerrit-PatchSet: 2
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list