This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/1861/4/src/bts.cpp File src/bts.cpp: Line 547: if (m_cur_fn - m_cur_rfn < 0) { is there a test case testing this, as I requested? I'm just wondering because subtracting two unsigned integers from each other should never be below zero, as far as I can tell. You can avoid signed arithmetic by stating "if (m_cur_rfn < m_cur_fn)" - but the test case should have pointed this out. Doesn't even the compiler warn about dead code in case of a check for an unsigned integer < 0? -- To view, visit https://gerrit.osmocom.org/1861 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74f00c11e5739d49f370ce6c357149e81d9aa759 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes