libosmocore[master]: gsm_04_08.h: add R99 MSCR and CBQ3 to SI3 Ctrl Chan Descr

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Feb 23 13:57:20 UTC 2017


Patch Set 2: Code-Review+2

> > I'm not sure if it is worth keeping around the old r98 data
 > > structure under a separate name. nobody can so far be using it,
 > as
 > > the name with r98 suffix is new.  What's the rationale to keep
 > it?
 > 
 > I was trying to follow the _r98 / _r99 pattern seen further below
 > in the file. Besides the spare bits distribution, there are no
 > changes in r99, only additions, but I assume we would like to
 > reflect which is present in which revision. 

I think in case there are only additions, there's no need for an additional data type.  one can just put a comment there indicating the release of the specs introducing the element, if needed.

-- 
To view, visit https://gerrit.osmocom.org/1859
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If87e07b5d04e1617155383e14c98d2125fdd0608
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list