libosmocore[master]: gsm_04_08.h: add struct with R99 names for SI3 Ctrl Chan Descr

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 22 16:07:44 UTC 2017


Patch Set 1:

> I'm not sure if it is worth keeping around the old r98 data
 > structure under a separate name. nobody can so far be using it, as
 > the name with r98 suffix is new.  What's the rationale to keep it?

I was trying to follow the _r98 / _r99 pattern seen further below in the file. Besides the spare bits distribution, there are no changes in r99, only additions, but I assume we would like to reflect which is present in which revision. gsm48_hdr_msg_type_r98() is also not used by anyone AFAICT.

-- 
To view, visit https://gerrit.osmocom.org/1859
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If87e07b5d04e1617155383e14c98d2125fdd0608
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list