libosmocore[master]: Expand and expose ctrl connection allocation

Harald Welte gerrit-no-reply at
Wed Feb 22 07:52:16 UTC 2017

Patch Set 2:

(1 comment)

also, a short explanation as to why we export the function would help.
File src/ctrl/control_if.c:

Line 383: 	ccon-> = data ? data : ccon;
> I think this is a bad decision. Let's plat the game of least surprise. I wa
I agree we should not use the private/data pointer with conditionally different types like this.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I522ed809cbebfd3d7dd08b4ed9137b39ff192e32
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Holger Freyther <holger at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at>
Gerrit-HasComments: Yes

More information about the gerrit-log mailing list