This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 2: (1 comment) also, a short explanation as to why we export the function would help. https://gerrit.osmocom.org/#/c/1629/2/src/ctrl/control_if.c File src/ctrl/control_if.c: Line 383: ccon->write_queue.bfd.data = data ? data : ccon; > I think this is a bad decision. Let's plat the game of least surprise. I wa I agree we should not use the private/data pointer with conditionally different types like this. -- To view, visit https://gerrit.osmocom.org/1629 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I522ed809cbebfd3d7dd08b4ed9137b39ff192e32 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: Yes