[MERGED] osmo-hlr[master]: auc_3g_test: allow to inc fake rand bytes upon rand request

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 22 07:19:01 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: auc_3g_test: allow to inc fake rand bytes upon rand request
......................................................................


auc_3g_test: allow to inc fake rand bytes upon rand request

Preparing for upcoming unit test, in a separate commit for cosmetic reasons
(setting the flag to false across the code).

Change-Id: I6b9899cd898eecc95b244432f416041b194a7187
---
M tests/auc/auc_3g_test.c
1 file changed, 16 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/auc/auc_3g_test.c b/tests/auc/auc_3g_test.c
index f1fa2c2..cb5e412 100644
--- a/tests/auc/auc_3g_test.c
+++ b/tests/auc/auc_3g_test.c
@@ -88,11 +88,23 @@
 	} while (0)
 
 uint8_t fake_rand[16] = { 0 };
+bool fake_rand_fixed = true;
+
+void next_rand(const char *hexstr, bool fixed)
+{
+	osmo_hexparse(hexstr, fake_rand, sizeof(fake_rand));
+	fake_rand_fixed = fixed;
+}
 
 int rand_get(uint8_t *rand, unsigned int len)
 {
+	int i;
 	OSMO_ASSERT(len <= sizeof(fake_rand));
 	memcpy(rand, fake_rand, len);
+	if (!fake_rand_fixed) {
+		for (i = 0; i < len; i++)
+			fake_rand[i] += 0x11;
+	}
 	return len;
 }
 
@@ -115,8 +127,7 @@
 
 	aud3g = (struct osmo_sub_auth_data){ 0 };
 
-	osmo_hexparse("39fa2f4e3d523d8619a73b4f65c3e14d",
-		      fake_rand, sizeof(fake_rand));
+	next_rand("39fa2f4e3d523d8619a73b4f65c3e14d", true);
 
 	vec = (struct osmo_auth_vector){ {0} };
 	VERBOSE_ASSERT(aud3g.u.umts.sqn, == 0, "%"PRIu64);
@@ -184,9 +195,7 @@
 		      aud3g.u.umts.k, sizeof(aud3g.u.umts.k));
 	osmo_hexparse("FB2A3D1B360F599ABAB99DB8669F8308",
 		      aud3g.u.umts.opc, sizeof(aud3g.u.umts.opc));
-
-	osmo_hexparse("39fa2f4e3d523d8619a73b4f65c3e14d",
-		      fake_rand, sizeof(fake_rand));
+	next_rand("39fa2f4e3d523d8619a73b4f65c3e14d", true);
 
 	vec = (struct osmo_auth_vector){ {0} };
 	VERBOSE_ASSERT(aud3g.u.umts.sqn, == 0, "%"PRIu64);
@@ -252,9 +261,7 @@
 		      aud3g.u.umts.k, sizeof(aud3g.u.umts.k));
 	osmo_hexparse("FB2A3D1B360F599ABAB99DB8669F8308",
 		      aud3g.u.umts.opc, sizeof(aud3g.u.umts.opc));
-
-	osmo_hexparse("39fa2f4e3d523d8619a73b4f65c3e14d",
-		      fake_rand, sizeof(fake_rand));
+	next_rand("39fa2f4e3d523d8619a73b4f65c3e14d", true);
 
 	vec = (struct osmo_auth_vector){ {0} };
 	VERBOSE_ASSERT(aud3g.u.umts.sqn, == 0, "%"PRIu64);
@@ -353,8 +360,7 @@
 	osmo_hexparse("39fa2f4e3d523d8619a73b4f65c3e14d",
 		      rand_auts, sizeof(rand_auts));
 	/* new RAND token for the next key */
-	osmo_hexparse("897210a0f7de278f0b8213098e098a3f",
-		      fake_rand, sizeof(fake_rand));
+	next_rand("897210a0f7de278f0b8213098e098a3f", true);
 	rc = auc_compute_vectors(&vec, 1, &aud2g, &aud3g, rand_auts, auts);
 	VERBOSE_ASSERT(rc, == 1, "%d");
 	/* The USIM's last sqn was 23, the calculated vector was 24, hence the

-- 
To view, visit https://gerrit.osmocom.org/1867
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6b9899cd898eecc95b244432f416041b194a7187
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list