osmo-hlr[master]: CTRL: add enable/disable packet service cmds

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Feb 21 11:31:21 UTC 2017


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1841/8/src/ctrl.c
File src/ctrl.c:

Line 41: 	if (db_subscr_get(ctx->dbc, cmd->value, NULL) < 0) {
I still think that this is not needed, because below db_subscr_ps() checks IMSI existence for free.


-- 
To view, visit https://gerrit.osmocom.org/1841
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23163ce8667292443ed61cb15c928357dba4b4be
Gerrit-PatchSet: 8
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list