osmo-hlr[master]: Add global HLR struct

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Feb 21 11:25:21 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/1856/2/src/hlr.h
File src/hlr.h:

Line 32: 	bool daemonize;
well, ok ... the cmdline options struct was separate on purpose, because a) they are no longer needed once main() has set things up and "should" remain limited to main(), b) to not have cmdline opt parsing access the server data structures to make semantically obvious that we should have some sort of validation and c) to have a separation between settings coming in via cmdline options and the actual settings used to run things -- there may be modifications or stuff from the VTY config. Historically, and across other Osmocom binaries, the cmd line opts were single global variables in main.c and I usually combine them in a cmdline_opts struct to indicate where it's coming from.

OTOH I wouldn't want to delay your work further based on these evangelics, I'll leave it up to you whether to keep it separate now. Once the VTY config starts to overlap these options, we can also separate them back...


-- 
To view, visit https://gerrit.osmocom.org/1856
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I275d3d54482f696e3378606b2406c7e0ad939e0f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list