osmo-hlr[master]: Make subscr parameter to db_subscr_get() optional

Max gerrit-no-reply at lists.osmocom.org
Mon Feb 20 17:01:52 UTC 2017


Patch Set 4:

I think it's a very bad idea to intermix "check" and "update" logic when it comes to DB. Yes, we can use (feels like abuse actually) SQL UPDATE function to deduce that if update fails than subscriber entry is missing but that makes code unnecessary hard to read and maintain. I'd rather have explicit check for subscriber availability using SQL SELECT.

-- 
To view, visit https://gerrit.osmocom.org/1853
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83b0f4a5dacb97614721690ef55bc1311624a58e
Gerrit-PatchSet: 4
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list