libosmocore[master]: logging: centrally define ctx and filter indexes
gerrit-no-reply at lists.osmocom.org
Mon Feb 20 14:53:44 UTC 2017
Patch Set 2:
> As this likely to be used very often I'd shorten it to LOGCTX_..
> and LOGFILTER_.. similar to existing LOGL_.. and LOGP.
Each LOGGING_FILTER_ is basically used twice. The LOGGING_CTX_ is used once per code path that would like to indicate an object to log. It's not *that* often but I see your point that we usually use just 'LOG' as prefix.
The main reason though to pick this long name was to avoid conflicts with previous names. Now that I look at it that's indeed only LOG_FILTER_ALL.
I'd prefer to keep the underscore, so would you be fine with LOG_FLT_ and LOG_CTX_ ?
To view, visit https://gerrit.osmocom.org/1844
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
More information about the gerrit-log