This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 5: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/1840/5/src/db.h File src/db.h: Line 7: SEL_BY_IMSI = 0, hmm, yes, this is better formatting, but in fact we usually rely on the enums getting sequential values implicitly. If we have a cosmetic change in this patch anyway, we could drop all the numbers instead... what do you think? https://gerrit.osmocom.org/#/c/1840/5/src/db_hlr.c File src/db_hlr.c: Line 84: int rc = 0; (var set but value never used) -- To view, visit https://gerrit.osmocom.org/1840 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24fb79e084b2dfa6a81b52f448b94a86e47014ef Gerrit-PatchSet: 5 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes