osmo-hlr[master]: Fix printf security warning

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Feb 20 12:17:43 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

sorry to -1 on a trivial patch, but plz clarify...

https://gerrit.osmocom.org/#/c/1851/1//COMMIT_MSG
Commit Message:

Line 7: Fix printf security warning
Please, as asked numerous times before, indicate the general area your patch modifies in the commit log summary. Also: what does "security warning" refer to, a compiler warning? A warning we're printing?


https://gerrit.osmocom.org/#/c/1851/1/src/db.c
File src/db.c:

Line 49: 		LOGP(DDB, LOGL_DEBUG, "%s\n", stmt);
Is the fix the added "\n" character, or are we having two line feeds now?


-- 
To view, visit https://gerrit.osmocom.org/1851
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e53de54ad1b9da18e1f414932cfd21be71ab154
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list