osmo-hlr[master]: Update DB routines

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Feb 19 15:43:07 UTC 2017


Patch Set 3: Code-Review-1

(3 comments)

what Harald said, and

https://gerrit.osmocom.org/#/c/1840/3//COMMIT_MSG
Commit Message:

Line 7: Update DB routines
"Update"? AFAICT this is adding routines.


Line 12: * fix printf security warning
can't find any 'printf security warning', where is it?


https://gerrit.osmocom.org/#/c/1840/3/src/db.h
File src/db.h:

Line 12: 	UPD_PURGE_CS_BY_IMSI = 5,
above formatting uses tabs before the '='


-- 
To view, visit https://gerrit.osmocom.org/1840
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24fb79e084b2dfa6a81b52f448b94a86e47014ef
Gerrit-PatchSet: 3
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list