openbsc[master]: Handle DSD from HLR

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Feb 19 09:05:07 UTC 2017


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/1838/2/openbsc/src/gprs/gprs_subscriber.c
File openbsc/src/gprs/gprs_subscriber.c:

Line 367: 			    "Rx GSUP message %s not yet implemented for CS\n",
a CS message will never be handled in GPRS/SGSN, so the "yet" is a bit misleading here.


Line 372: 		gsm0408_gprs_access_cancelled(subscr->sgsn_data->mm,
did you verify that this is sufficient?  Basically we need to close any existing/established PDP contexts and detach the subscriber on mobility management.


-- 
To view, visit https://gerrit.osmocom.org/1838
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6b9b494fa58bcb95bd550c49f8204f00f8fdf628
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list