libosmocore[master]: vty: fix "everything" logging option

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sat Feb 18 00:52:53 UTC 2017


Patch Set 7:

(1 comment)

https://gerrit.osmocom.org/#/c/1582/7/include/osmocom/core/logging.h
File include/osmocom/core/logging.h:

Line 92:    before adding anything to above */
Hmm. The loglevel nr space spans 0..255, where 0 is special and means "nothing"; 1 is most verbose and 8 is least verbose. Then out of 0..255 pick LOGL_EVERY=32 to mean "everything"?  IMHO most sensible would be to swap so that 0 means everything and 255 means nothing. If we're not going to swap, why not take 255 for "everything"? ... Then again all of this logging code is kind of crooked and historically-grown-like, so actually 32 can't make it much worse either ;)


-- 
To view, visit https://gerrit.osmocom.org/1582
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib51987fb2f64a70fca130f3799dc8fd71cc7085c
Gerrit-PatchSet: 7
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list