osmo-pcu[master]: PDCH allocation across two TRX

Max gerrit-no-reply at lists.osmocom.org
Fri Feb 17 09:33:17 UTC 2017


Patch Set 4: Code-Review-1

(3 comments)

Please double-check that _every_ doxygen header you wrote actually match function behavior and parameters. Please, do it for _every_ single function you wrote in this patch - not just the one you got feedback for. Otherwise we will be in the cycle "review -> fix one function -> review -> fix another function" for months. Thank you for understanding.

https://gerrit.osmocom.org/#/c/1512/4/src/bts.cpp
File src/bts.cpp:

Line 458: /*! \brief: Prepares all the TRXs which can be used to host a perticulat TBF
typo: particular


Line 460:  *  \param[in] *_trx The bool
this function has 1 parameter but 2 \param entries - fix please


Line 463:  *  \returns -EINVAL if no PDCH available else returns list of valid TRXs
this is incorrect too - it returns 0 on success and fills in _trx parameter which should be marked as [out]


-- 
To view, visit https://gerrit.osmocom.org/1512
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I222c3340872ffa1dd6e8fabe5276d793e660f67d
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list