[PATCH] osmo-pcu[master]: dl tbf: calculate CPS only for EGPRS

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Feb 14 11:27:22 UTC 2017


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1774

to look at the new patch set (#3).

dl tbf: calculate CPS only for EGPRS

Patch-by: Aravind Sirsikar <Arvind.Sirsikar at radisys.com>
Change-Id: I81b8e1d10bfe9efba3a9f04bced66f87d93285dd
---
M src/tbf_dl.cpp
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/74/1774/3

diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index 78f06e9..c04a84e 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -762,8 +762,11 @@
 			msg_data, block_data);
 	}
 
-	OSMO_ASSERT(ARRAY_SIZE(punct) >= 2);
-	rlc.cps = gprs_rlc_mcs_cps(cs, punct[0], punct[1], need_padding);
+	/* Calculate CPS only for EGPRS case */
+	if (cs.isEgprs()) {
+		OSMO_ASSERT(ARRAY_SIZE(punct) >= 2);
+		rlc.cps = gprs_rlc_mcs_cps(cs, punct[0], punct[1], need_padding);
+	}
 
 	/* If the TBF has just started, relate frames_since_last_poll to the
 	 * current fn */

-- 
To view, visit https://gerrit.osmocom.org/1774
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I81b8e1d10bfe9efba3a9f04bced66f87d93285dd
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>


More information about the gerrit-log mailing list