osmo-bts[master]: osmo-trx-bts: Fix incorrect setting of RXGAIN and POWER para...
gerrit-no-reply at lists.osmocom.org
Fri Feb 10 10:02:14 UTC 2017
Patch Set 2:
> > changing type of _valid and _sent variables to bool requires more
> changes in the code which are unrelated with this fix
> Could you elaborate on this - which code are you referring to? If
> it's indeed used as boolean only, than there should be no extra
> code changes necessary apart from variable initialization and even
> that is just to avoid warnings.
I mean that we should change type of all _valid, _sent variables in struct trx_config (not only for power and rxgain) and also all assignments (in l1_if.c and trx_vty.c files) to these variables should be change to true/false.
I think it is good scope for separate patch.
To view, visit https://gerrit.osmocom.org/1785
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
More information about the gerrit-log