This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Ivan Kluchnikov gerrit-no-reply at lists.osmocom.orgPatch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/1785/1/src/osmo-bts-trx/l1_if.h File src/osmo-bts-trx/l1_if.h: Line 23: int rxgain_valid; > Seems like _valid and _sent are only used as bool. If so then better use bo Yes, agree, but changing type of _valid and _sent variables to bool requires more changes in the code which are unrelated with this fix, so I think it is better to make separate patch for changing type of all _valid and _sent variables in the code. Does it make sense? Line 28: uint8_t power; > Why signed type? Can it have negative value in some case? If not, than bett Good point, fixed it. -- To view, visit https://gerrit.osmocom.org/1785 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4861a59d10d1ef91954e0c6ea265e66dec08844f Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Ivan Kluchnikov <kluchnikovi at gmail.com> Gerrit-Reviewer: Ivan Kluchnikov <kluchnikovi at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-HasComments: Yes