[PATCH] osmo-bts[master]: osmo-trx-bts: Fix incorrect bts shutdown procedure in case o...

Max gerrit-no-reply at lists.osmocom.org
Thu Feb 9 18:54:28 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1789

to look at the new patch set (#2).

osmo-trx-bts: Fix incorrect bts shutdown procedure in case of clock loss from osmo-trx

This issue occurs in case of osmo-trx restart which leads to losing clock from osmo-trx.
Function bts_shutdown from common/bts.c should be used in this case for proper bts shutdown.

Change-Id: Ie65cf2e8f98cb8bf3314a00048aa53c1f8cd4c25
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 1 insertion(+), 13 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/1789/2

diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index d946ad5..9c676d7 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1408,19 +1408,7 @@
 no_clock:
 		transceiver_available = 0;
 
-		/* flush pending messages of transceiver */
-		/* close all logical channels and reset timeslots */
-		llist_for_each_entry(trx, &bts->trx_list, list) {
-			struct phy_instance *pinst = trx_phy_instance(trx);
-			struct trx_l1h *l1h = pinst->u.osmotrx.hdl;
-			trx_if_flush(l1h);
-			trx_sched_reset(&l1h->l1s);
-			if (trx->nr == 0)
-				trx_if_cmd_poweroff(l1h);
-		}
-
-		/* tell BSC */
-		check_transceiver_availability(bts, 0);
+		bts_shutdown(bts, "No clock from osmo-trx");
 
 		return;
 	}

-- 
To view, visit https://gerrit.osmocom.org/1789
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie65cf2e8f98cb8bf3314a00048aa53c1f8cd4c25
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list