osmo-bts[master]: osmo-trx-bts: Fix incorrect setting of RXGAIN and POWER para...

Max gerrit-no-reply at lists.osmocom.org
Thu Feb 9 18:51:57 UTC 2017


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/1785/1/src/osmo-bts-trx/l1_if.h
File src/osmo-bts-trx/l1_if.h:

Line 23: 	int			rxgain_valid;
Seems like _valid and _sent are only used as bool. If so then better use bool type.


Line 28: 	int			power;
Why signed type? Can it have negative value in some case? If not, than better use some unsigned type.


-- 
To view, visit https://gerrit.osmocom.org/1785
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4861a59d10d1ef91954e0c6ea265e66dec08844f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list