[PATCH] osmo-bts[master]: osmo-bts: Fix procedure of writing configuration for each ph...

Ivan Kluchnikov gerrit-no-reply at lists.osmocom.org
Thu Feb 9 16:35:56 UTC 2017


Review at  https://gerrit.osmocom.org/1787

osmo-bts: Fix procedure of writing configuration for each phy instance

bts_model_config_write_phy_inst function should be called from function config_write_phy_single for writing configuration parameters for each phy inst.
Also we should add functions for each bts_model for writing phy inst parameters to configuration (osmo-trx-bts already has implementation of this function).

Change-Id: I27a13ff1813688cb30062450d8457a5083ba2a34
---
M src/common/vty.c
M src/osmo-bts-litecell15/lc15bts_vty.c
M src/osmo-bts-octphy/octphy_vty.c
M src/osmo-bts-sysmo/sysmobts_vty.c
4 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/1787/1

diff --git a/src/common/vty.c b/src/common/vty.c
index b48afa4..646ac87 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -358,6 +358,7 @@
 		if (!pinst)
 			break;
 		vty_out(vty, " instance %u%s", pinst->num, VTY_NEWLINE);
+		bts_model_config_write_phy_inst(vty, pinst);
 	}
 }
 
diff --git a/src/osmo-bts-litecell15/lc15bts_vty.c b/src/osmo-bts-litecell15/lc15bts_vty.c
index 0ffe663..a76dc85 100644
--- a/src/osmo-bts-litecell15/lc15bts_vty.c
+++ b/src/osmo-bts-litecell15/lc15bts_vty.c
@@ -354,6 +354,10 @@
 		write_phy_inst(vty, pinst);
 }
 
+void bts_model_config_write_phy_inst(struct vty *vty, struct phy_instance *pinst)
+{
+}
+
 int bts_model_vty_init(struct gsm_bts *bts)
 {
 	vty_bts = bts;
diff --git a/src/osmo-bts-octphy/octphy_vty.c b/src/osmo-bts-octphy/octphy_vty.c
index c2d1fbb..abfac1e 100644
--- a/src/osmo-bts-octphy/octphy_vty.c
+++ b/src/osmo-bts-octphy/octphy_vty.c
@@ -219,6 +219,10 @@
 		VTY_NEWLINE);
 }
 
+void bts_model_config_write_phy_inst(struct vty *vty, struct phy_instance *pinst)
+{
+}
+
 void bts_model_config_write_bts(struct vty *vty, struct gsm_bts *bts)
 {
 }
diff --git a/src/osmo-bts-sysmo/sysmobts_vty.c b/src/osmo-bts-sysmo/sysmobts_vty.c
index e67d8be..c1056dd 100644
--- a/src/osmo-bts-sysmo/sysmobts_vty.c
+++ b/src/osmo-bts-sysmo/sysmobts_vty.c
@@ -477,6 +477,10 @@
 		write_phy_inst(vty, pinst);
 }
 
+void bts_model_config_write_phy_inst(struct vty *vty, struct phy_instance *pinst)
+{
+}
+
 int bts_model_vty_init(struct gsm_bts *bts)
 {
 	vty_bts = bts;

-- 
To view, visit https://gerrit.osmocom.org/1787
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27a13ff1813688cb30062450d8457a5083ba2a34
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Ivan Kluchnikov <kluchnikovi at gmail.com>


More information about the gerrit-log mailing list