osmo-bts[master]: SACCH: fix sending of SI with an enum value > 7

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Feb 8 18:34:36 UTC 2017


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1778/2/src/common/rsl.c
File src/common/rsl.c:

Line 690: 		int osmo_si = osmo_rsl2sitype(rsl_si);
I think it's better to use variable of the type returned by function - in this case "enum osmo_sysinfo_type".


-- 
To view, visit https://gerrit.osmocom.org/1778
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85fa9a50691601bcd103845c6811caa061a39824
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list