libosmocore[master]: Fix type of abis_nm_att_tlvdef_ipa variable

Ivan Kluchnikov gerrit-no-reply at lists.osmocom.org
Wed Feb 8 16:47:16 UTC 2017


Patch Set 1:

> good catch. but I'm not sure about the solution. the proper
 > solution might be to create a copy in osmo-bts.  So the library
 > only provides const data fro the respective dialects, and the
 > application must make a local copy and merge/modify/patch the local
 > copy only.
 > 
 > This also would address use cases where a single application needs
 > to understand multiple dialects (and thus have multiple differently
 > patched tables).

Yes, agree, it is better to create a copy in application, I will prepare patch for osmo-bts and submit it for review.

-- 
To view, visit https://gerrit.osmocom.org/1770
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57acf45bf5debe24c7ceb6c45ef0940e89e51a61
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No


More information about the gerrit-log mailing list