osmo-bts[master]: all models: fix vty write: bts_model_config_write_phy
gerrit-no-reply at lists.osmocom.org
Wed Feb 8 13:43:13 UTC 2017
Patch Set 1:
> How it wasn't caught by tests? Maybe add explicit test to make sure
> this won't be broken again?
Well, we still don't have VTY tests for osmo-bts.
The missing _write_phy_inst() wasn't caught because it was never called.
The missing _write_phy() in octphy should have resulted in an undefined reference, not sure why it isn't caught.
To view, visit https://gerrit.osmocom.org/1761
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
More information about the gerrit-log