osmo-bts[master]: all models: fix vty write: bts_model_config_write_phy

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 8 13:43:13 UTC 2017


Patch Set 1:

> How it wasn't caught by tests? Maybe add explicit test to make sure
 > this won't be broken again?

Well, we still don't have VTY tests for osmo-bts.

The missing _write_phy_inst() wasn't caught because it was never called.

The missing _write_phy() in octphy should have resulted in an undefined reference, not sure why it isn't caught.

-- 
To view, visit https://gerrit.osmocom.org/1761
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc54fa70045c8fa58e78cf9f788c21a437edfbd4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list