osmo-pcu[master]: remove pcu own bitvector implementation

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Feb 8 11:02:55 UTC 2017


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/1753/2/src/csn1.cpp
File src/csn1.cpp:

Line 404: 	  Status = csnStreamDecoder(&arT, (const CSN_DESCR*)pDescr->descr.ptr, vector, readIndex, pui8);
> Whitespace change? Just double-checking.
Yes, better not have it..


https://gerrit.osmocom.org/#/c/1753/2/src/encoding.cpp
File src/encoding.cpp:

Line 88: 	bitvec_write_field(dest, &wp, 3, 2);   // "HH"
> You sure it's a safe replacement? Have you tested it with actual phone?
Just a safety question or do you see something?


-- 
To view, visit https://gerrit.osmocom.org/1753
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8f797631d89aa12b6e48efb2dc153a3e2f059f7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list