libosmocore[master]: vty: fix "everything" logging option

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 8 08:28:03 UTC 2017


Patch Set 3: Code-Review+1

(2 comments)

let's keep this in review for a bit until other people had a chance to comment.  It is quite a singnificant change from the (many years long) broken behavior...

https://gerrit.osmocom.org/#/c/1582/3/src/logging.c
File src/logging.c:

Line 163: 	/* explicit check for "everything" loglevel */
we can see from the two lines of code that it is an explicit check.  However, what I cannot see is why it is required, given that the loglevel_strs contain a corresponding record.  Please check if this is really needed, and if so: clarify in the comment. Only difference seems to be the case?


Line 176: 	if (lvl == LOGL_EVERY)
same as above?


-- 
To view, visit https://gerrit.osmocom.org/1582
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib51987fb2f64a70fca130f3799dc8fd71cc7085c
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list