libosmocore[master]: vty: fix "everything" logging option

Harald Welte gerrit-no-reply at
Wed Feb 8 08:28:03 UTC 2017

Patch Set 3: Code-Review+1


let's keep this in review for a bit until other people had a chance to comment.  It is quite a singnificant change from the (many years long) broken behavior...
File src/logging.c:

Line 163: 	/* explicit check for "everything" loglevel */
we can see from the two lines of code that it is an explicit check.  However, what I cannot see is why it is required, given that the loglevel_strs contain a corresponding record.  Please check if this is really needed, and if so: clarify in the comment. Only difference seems to be the case?

Line 176: 	if (lvl == LOGL_EVERY)
same as above?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib51987fb2f64a70fca130f3799dc8fd71cc7085c
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at>
Gerrit-Reviewer: Harald Welte <laforge at>
Gerrit-Reviewer: Holger Freyther <holger at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at>
Gerrit-HasComments: Yes

More information about the gerrit-log mailing list