libosmocore[master]: vty: fix "everything" logging option
gerrit-no-reply at lists.osmocom.org
Wed Feb 8 08:28:03 UTC 2017
Patch Set 3: Code-Review+1
let's keep this in review for a bit until other people had a chance to comment. It is quite a singnificant change from the (many years long) broken behavior...
Line 163: /* explicit check for "everything" loglevel */
we can see from the two lines of code that it is an explicit check. However, what I cannot see is why it is required, given that the loglevel_strs contain a corresponding record. Please check if this is really needed, and if so: clarify in the comment. Only difference seems to be the case?
Line 176: if (lvl == LOGL_EVERY)
same as above?
To view, visit https://gerrit.osmocom.org/1582
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
More information about the gerrit-log