[MERGED] osmo-bts[master]: Fix SACCH channel release indication not sent to BSC after l...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Feb 7 00:39:42 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: Fix SACCH channel release indication not sent to BSC after location update.
......................................................................


Fix SACCH channel release indication not sent to BSC after location update.

Based on GSM 04.08 3.4.13 RR connection release procedure, after the network
sends a deactivate SACCH it receives DISC from MS which cause BTS to
send RLL release indication to BSC in order to stop T3109 timer. It has been
found that after a location update BSC never receives RLL release indication
which causes a T3109 timeout because no TCH is currently allocated. This fix
ensures RLL release indication to be sent to BSC when no TCH is allocated
in the particular case of a location update.

Change-Id: Ibe2a365641eb8c9a7f0a462b7393ec3fd28cc366
---
M src/common/rsl.c
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/rsl.c b/src/common/rsl.c
index 74d835f..5c4e4ff 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2284,7 +2284,8 @@
 			gsm_lchan_name(lchan), rsl_msg_name(rh->msg_type));
 
 		/* REL_IND handling */
-		if (rh->msg_type == RSL_MT_REL_IND) {
+		if (rh->msg_type == RSL_MT_REL_IND &&
+			(lchan->type == GSM_LCHAN_TCH_F || lchan->type == GSM_LCHAN_TCH_H)) {
 			LOGP(DRSL, LOGL_INFO, "%s Scheduling %s to L3 in next associated TCH-RTS.ind\n",
 				gsm_lchan_name(lchan),
 				rsl_msg_name(rh->msg_type));

-- 
To view, visit https://gerrit.osmocom.org/1747
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe2a365641eb8c9a7f0a462b7393ec3fd28cc366
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: jfdionne <jf.dionne at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list