[MERGED] osmo-hlr[master]: UMTS AKA resync: fix argument ordering

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Feb 6 14:09:23 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: UMTS AKA resync: fix argument ordering
......................................................................


UMTS AKA resync: fix argument ordering

According to libosmocore change-id I0dcbd49759fc32d3b8974102dbd1d6703364ebf4
this argument ordering will not result in successful AUTS. Pass in order
auts, auts_rand so that these are passed correctly to our milenage code.

Change-Id: I6aa19004ec27bad5e9c2bf688d9bbc55d697ccb0
---
M src/auc.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/auc.c b/src/auc.c
index bec3ea6..3f3db34 100644
--- a/src/auc.c
+++ b/src/auc.c
@@ -71,8 +71,8 @@
 				       i, num_vec);
 			if (rand_auts && auts)
 				rc = osmo_auth_gen_vec_auts(vec+i, aud3g,
-							    rand_auts,
-							    auts, rand);
+							    auts, rand_auts,
+							    rand);
 			else
 				rc = osmo_auth_gen_vec(vec+i, aud3g, rand);
 			if (rc < 0) {

-- 
To view, visit https://gerrit.osmocom.org/1739
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6aa19004ec27bad5e9c2bf688d9bbc55d697ccb0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list