openbsc[master]: add struct bsc_sub, separating libbsc from gsm_subscriber

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Feb 6 12:46:21 UTC 2017


Patch Set 4:

Would you be fine with calling the structs *_subscriber and still prefix the functions with the shorter *_sub_?

Background: In vlr.h, we have subscriber related things except vlr_subscriber itself prefixed 'vlr_sub_' (from you). I actually liked its brevity because I had to type a lot of subscriber (and it's a word that I often mistype for some reason). That's why I went on to use bsc_sub_ and gprs_sub_, and thought why not name the structs the same as the function prefix.

(still leaving as -2 because the issue that testing this failed is not resolved yet; but will be fairly soon)

-- 
To view, visit https://gerrit.osmocom.org/1682
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No


More information about the gerrit-log mailing list