osmo-pcu[master]: remove pcu own bitvector implementation

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sat Feb 4 15:11:33 UTC 2017


Patch Set 2:

(1 comment)

I will have to look carefully. On first sight you seem to add the & at all call sites. Another approach is outlined in the comment of bitvector.h

In general I agree with this change (after max had moved the code to libosmocore)

https://gerrit.osmocom.org/#/c/1753/2/src/bitvector.h
File src/bitvector.h:

Line 44
This was one "trick" to use function overloading and outer scope look-up to not have to update all client code..


-- 
To view, visit https://gerrit.osmocom.org/1753
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8f797631d89aa12b6e48efb2dc153a3e2f059f7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list