openbsc[master]: gprs_sgsn.c: initialize ptmsi with 0xdeadbeef

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Feb 4 06:01:38 UTC 2017


Patch Set 2:

I also though WTF How could this happened, when I saw it. But I can not reproduce it atm. The man page describes under the point of RAND_pseudo_bytes():
"The contents of buf is mixed into the entropy pool before retrieving the new pseudo-random bytes unless disabled at compile time (see FAQ). 
But sgsn is using RAND_bytes().

It might be a side effect of a Use-after-free which I traced down before.
Should I abandon this change or should we take it anyhow?

-- 
To view, visit https://gerrit.osmocom.org/1749
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc2d585c5db899e6af20104211e32faf3822633a
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: No


More information about the gerrit-log mailing list