openbsc[master]: tests/bsc & bsc-nat: fix mem leaks of talloc ctx

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Feb 4 03:53:40 UTC 2017


Patch Set 2:

> We have to be careful here. Is there a real leak and you silence it
 > because of the recursive nature of talloc_free(ctx) or is it just a
 > context being leaked by talloc?
 > 
 > For the commit message it would help to know which leak was fixed.

I see. So we should add talloc asserts on the allocated memblocks. Wich some tests already do. I've updated the commit message.

-- 
To view, visit https://gerrit.osmocom.org/1752
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1f08df7bcfd1d115824dc1f30577f632bb32615
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-HasComments: No


More information about the gerrit-log mailing list