[PATCH] osmo-pcu[master]: tbf.cpp: use new tlli instead of old tlli

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Sat Feb 4 03:41:16 UTC 2017


Hello Jenkins Builder, Holger Freyther,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1663

to look at the new patch set (#2).

tbf.cpp: use new tlli instead of old tlli

The old tlli might be 0x00000000.

Change-Id: I2fd6fec022506e203d05e91c36ccd9e020ff816c
---
M src/tbf.cpp
M tests/tbf/TbfTest.err
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/63/1663/2

diff --git a/src/tbf.cpp b/src/tbf.cpp
index 0d28c5c..d9eb4bb 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -1311,7 +1311,7 @@
 	if (dl_tbf && dl_tbf->ms() != ms()) {
 		LOGP(DRLCMACUL, LOGL_NOTICE, "Got RACH from "
 			"TLLI=0x%08x while %s still exists. "
-			"Killing pending DL TBF\n", tlli(),
+			"Killing pending DL TBF\n", new_tlli,
 			tbf_name(dl_tbf));
 		tbf_free(dl_tbf);
 		dl_tbf = NULL;
@@ -1319,7 +1319,7 @@
 	if (ul_tbf && ul_tbf->ms() != ms()) {
 		LOGP(DRLCMACUL, LOGL_NOTICE, "Got RACH from "
 			"TLLI=0x%08x while %s still exists. "
-			"Killing pending UL TBF\n", tlli(),
+			"Killing pending UL TBF\n", new_tlli,
 			tbf_name(ul_tbf));
 		tbf_free(ul_tbf);
 		ul_tbf = NULL;
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index 575b7fb..b8fb451 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -2192,7 +2192,7 @@
 - BSN 0 storing in window (0..63)
 TBF(TFI=0 TLLI=0x00000000 DIR=UL STATE=FLOW): data_length=20, data=f1 22 33 44 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
 Decoded premier TLLI=0x00000000 of UL DATA TFI=0.
-Got RACH from TLLI=0x00000000 while TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) still exists. Killing pending DL TBF
+Got RACH from TLLI=0xf1223344 while TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) still exists. Killing pending DL TBF
 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=ASSIGN) changes state from ASSIGN to RELEASING
 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=RELEASING) free
 TBF(TFI=0 TLLI=0xf1223344 DIR=DL STATE=RELEASING) stopping timer 0.

-- 
To view, visit https://gerrit.osmocom.org/1663
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2fd6fec022506e203d05e91c36ccd9e020ff816c
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list