libosmocore[master]: utils/conv_gen.py: improve application flexibility

Holger Freyther gerrit-no-reply at lists.osmocom.org
Thu Feb 2 13:38:20 UTC 2017


Patch Set 4:

> usage: conv_gen.py [-h] [-p PREFIX] [-n TARGET_NAME] [-P
 > TARGET_PATH]
 > {gen_codes,gen_vectors,gen_header} {gsm}
 

 > witch the previous one. I looked for opportunity to customize the
 > help output,
 > but such approach requires to create a new class and redefine some
 > internal methods.
 > 
 > So, if usage of argparse is mandatory, I will rewrite the code, and
 > will not care about help.

okay I see that you can not describe gen_codes here. I think it is still better to use argparse and if needed write a formatter_class or custom command (e.g. how is gen_codes, gen_vectors added tot he parser?)

-- 
To view, visit https://gerrit.osmocom.org/1584
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b476b00234c17f78b41d695cf3bfd13edb64c28
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-HasComments: No


More information about the gerrit-log mailing list