osmo-iuh[master]: cs RAB: lower guaranteedBitrate

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Feb 1 13:59:55 UTC 2017


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1643/2/src/ranap_msg_factory.c
File src/ranap_msg_factory.c:

PS2, Line 562: v
I think it's best to add the guaranteed and max bitrate as function arguments here and use a #define for the default vailue (at least in case multiple callers call it, if it's only one caller the raw numbers are probably easier to read)


-- 
To view, visit https://gerrit.osmocom.org/1643
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7eecca43d62a6a020466e9b8dc8b566ca988f9f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes


More information about the gerrit-log mailing list