[PATCH] osmo-iuh[master]: cs RAB: set allocationOrRetentionPriority=lowest

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Feb 1 13:10:38 UTC 2017


Hello Jenkins Builder, Holger Freyther,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1645

to look at the new patch set (#2).

cs RAB: set allocationOrRetentionPriority=lowest

This is mimicking the IEs found in a trace from a production 3G environment. We
have no reason to add this other than knowing that other operators seem to do
this.

This came up while trying to fix voice RAB for the nano3G, but this patch had
no effect on that. Now that it's here, we might as well keep it.

Change-Id: I0d7dc32bc93fa0a4d316f8378b3735dc11e87071
---
M src/ranap_msg_factory.c
M src/tests/test-ranap.ok
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/45/1645/2

diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c
index 89ffffb..65c1dab 100644
--- a/src/ranap_msg_factory.c
+++ b/src/ranap_msg_factory.c
@@ -581,7 +581,7 @@
 	ASN_SEQUENCE_ADD(&rab->sDU_Parameters, sdui);
 
 	rab->transferDelay = new_long(80);
-	rab->allocationOrRetentionPriority = new_alloc_ret_prio(RANAP_PriorityLevel_no_priority, 0, 1, 0);
+	rab->allocationOrRetentionPriority = new_alloc_ret_prio(RANAP_PriorityLevel_lowest, 0, 1, 0);
 
 	rab->sourceStatisticsDescriptor = new_long(RANAP_SourceStatisticsDescriptor_speech);
 
diff --git a/src/tests/test-ranap.ok b/src/tests/test-ranap.ok
index 0ab99b0..e10a718 100644
--- a/src/tests/test-ranap.ok
+++ b/src/tests/test-ranap.ok
@@ -90,7 +90,7 @@
     <firstValue>
         78 02 CD 80 10 2F A7 20 1A 2C 00 00 F4 4C 64 0A 
         02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 
-        28 14 00 3C 40 00 00 00 50 3D 02 00 02 0D C0 35 
+        28 14 00 3C 40 00 00 00 50 39 02 00 02 0D C0 35 
         00 01 0A 0B 0C 0D 40 09 26 00 00
     </firstValue>
     <secondCriticality><ignore/></secondCriticality>
@@ -103,11 +103,11 @@
         00 00 01 00 35 00 3B 78 02 CD 80 10 2F A7 20 1A 
         2C 00 00 F4 4C 64 0A 02 80 00 51 40 00 27 20 28 
         14 00 67 40 00 00 22 28 14 00 3C 40 00 00 00 50 
-        3D 02 00 02 0D C0 35 00 01 0A 0B 0C 0D 40 09 26 
+        39 02 00 02 0D C0 35 00 01 0A 0B 0C 0D 40 09 26 
         00 00 40 01 00
     </value>
 </RANAP_IE>
-00 00 00 4c 00 00 01 00 36 40 45 00 00 01 00 35 00 3b 78 02 cd 80 10 2f a7 20 1a 2c 00 00 f4 4c 64 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 50 3d 02 00 02 0d c0 35 00 01 0a 0b 0c 0d 40 09 26 00 00 40 01 00 
+00 00 00 4c 00 00 01 00 36 40 45 00 00 01 00 35 00 3b 78 02 cd 80 10 2f a7 20 1a 2c 00 00 f4 4c 64 0a 02 80 00 51 40 00 27 20 28 14 00 67 40 00 00 22 28 14 00 3c 40 00 00 00 50 39 02 00 02 0d c0 35 00 01 0a 0b 0c 0d 40 09 26 00 00 40 01 00 
 
 ==> RAB ASSIGNMENT COMMAND (DATA)
 <RANAP_ProtocolIE-FieldPair>

-- 
To view, visit https://gerrit.osmocom.org/1645
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0d7dc32bc93fa0a4d316f8378b3735dc11e87071
Gerrit-PatchSet: 2
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder


More information about the gerrit-log mailing list